blogs/hugo
1
0
Fork 0
mirror of https://github.com/gohugoio/hugo.git synced 2026-08-24 15:28:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

modules/npm: Fix false stale warning after npm pack

Browse Source 
Closes #14959

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Joe Mooring
2026-05-27 13:19:19 -07:00
committed by Bjørn Erik Pedersen
parent 21e9868fe2
commit 59f35cd985
3 changed files with 38 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/npm/package_builder.go
+14 -13
View File
@@ -207,6 +207,19 @@ func Pack(sourceFs, assetsWithDuplicatesPreservedFs afero.Fs, mods modules.Modul
devDependenciesKey: moduleDevDeps,
}
if err := sourceFs.MkdirAll(files.FolderPackagesHugoAutoGen, 0o777); err != nil {
return err
}
if err := writeJSON(sourceFs, workspacePackageJSON, autoGenPkg); err != nil {
return err
}
// 5. Ensure root package.json references the workspace.
if err := ensureWorkspaceRef(sourceFs, workspacePath); err != nil {
return err
}
// 6. Write metadata for the final on-disk package state.
metaFile := packageMeta{
Sum: PackageFilesSum(sourceFs, mods),
DependencySources: dependencySources{
@@ -214,19 +227,7 @@ func Pack(sourceFs, assetsWithDuplicatesPreservedFs afero.Fs, mods modules.Modul
DevDependencies: moduleDevDepsComments,
},
}
if err := sourceFs.MkdirAll(files.FolderPackagesHugoAutoGen, 0o777); err != nil {
return err
}
if err := writeJSON(sourceFs, workspacePackageJSON, autoGenPkg); err != nil {
return err
}
if err := writeJSON(sourceFs, workspacePackageMetaJSON, metaFile); err != nil {
return err
}
// 5. Ensure root package.json references the workspace.
return ensureWorkspaceRef(sourceFs, workspacePath)
return writeJSON(sourceFs, workspacePackageMetaJSON, metaFile)
}
// ensureWorkspaceRef adds workspacePath to the "workspaces" array in root
modules/npm/package_builder_integration_test.go
+20 -3
View File
@@ -21,6 +21,7 @@ import (
"github.com/gohugoio/hugo/hugolib"
"github.com/gohugoio/hugo/modules"
"github.com/gohugoio/hugo/modules/npm"
"github.com/spf13/afero"
)
func getPackageBuilderTestFiles() string {
@@ -49,7 +50,7 @@ PACKAGE_CONTENT
"version": "0.1.1",
"dependencies": {
"react-dom": "1.1.1",
"tailwindcss": "1.2.0",
"tailwindcss": "1.2.0",
"@babel/cli": "7.8.4",
"@babel/core": "7.9.0",
"@babel/preset-env": "7.9.5"
@@ -70,9 +71,25 @@ func TestPackageBuilder(t *testing.T) {
files := getPackageBuilderTestFiles()
b := hugolib.Test(t, files)
fs := b.H.Fs.WorkingDirReadOnly
sourceFs := b.H.BaseFs.ProjectSourceFs
assetsFs := b.H.BaseFs.AssetsWithDuplicatesPreserved.Fs
mods := b.H.Configs.Modules
sum := npm.PackageFilesSum(fs, b.H.AllModules())
b.Assert(sum, qt.Equals, "ce880d142ad9a16a")
b.Assert(sum, qt.Equals, "528bb6507993888c")
b.Assert(npm.Pack(sourceFs, assetsFs, mods), qt.IsNil)
b.Assert(npm.NpmPackNeedsUpdate(sourceFs, mods), qt.IsFalse)
meta1, err := afero.ReadFile(sourceFs, "packages/hugoautogen/hugo_packagemeta.json")
b.Assert(err, qt.IsNil)
b.Assert(npm.Pack(sourceFs, assetsFs, mods), qt.IsNil)
b.Assert(npm.NpmPackNeedsUpdate(sourceFs, mods), qt.IsFalse)
meta2, err := afero.ReadFile(sourceFs, "packages/hugoautogen/hugo_packagemeta.json")
b.Assert(err, qt.IsNil)
b.Assert(string(meta2), qt.Equals, string(meta1))
}
func BenchmarkPackageFilesSum(b *testing.B) {
@@ -83,6 +100,6 @@ func BenchmarkPackageFilesSum(b *testing.B) {
for b.Loop() {
sum := npm.PackageFilesSum(fs, modules.Modules{})
bb.Assert(sum, qt.Equals, "ce880d142ad9a16a")
bb.Assert(sum, qt.Equals, "528bb6507993888c")
}
}