From b7ed108f907562960ed7bca8b4bfc1dd805fe306 Mon Sep 17 00:00:00 2001
From: Joe Mooring <joe.mooring@veriphor.com>
Date: Sun, 26 Jan 2025 18:33:54 -0800
Subject: [PATCH] Improve js.Build example and presentation of options

---
 content/en/functions/js/Build.md           | 32 +++++----
 content/en/functions/js/_common/options.md | 75 ++++++++++++++--------
 2 files changed, 68 insertions(+), 39 deletions(-)

diff --git a/content/en/functions/js/Build.md b/content/en/functions/js/Build.md
index 56118213f..3e78e8e98 100644
--- a/content/en/functions/js/Build.md
+++ b/content/en/functions/js/Build.md
@@ -28,31 +28,37 @@ The `js.Build` function uses the [evanw/esbuild] package to:
 
 ```go-html-template
 {{ with resources.Get "js/main.js" }}
-  {{ if hugo.IsDevelopment }}
-    {{ with . | js.Build }}
+  {{ $opts := dict
+    "minify" hugo.IsProduction
+    "sourceMap" (cond hugo.IsProduction "" "external")
+    "targetPath" "js/main.js"
+  }}
+  {{ with . | js.Build $opts }}
+    {{ if hugo.IsProduction }}
+      {{ with . | fingerprint }}
+        <script src="{{ .RelPermalink }}" integrity="{{ .Data.Integrity }}" crossorigin="anonymous"></script>
+      {{ end }}
+    {{ else }}
       <script src="{{ .RelPermalink }}"></script>
     {{ end }}
-  {{ else }}
-    {{ $opts := dict "minify" true }}
-    {{ with . | js.Build $opts | fingerprint }}
-      <script src="{{ .RelPermalink }}" integrity="{{ .Data.Integrity }}" crossorigin="anonymous"></script>
-    {{ end }}
   {{ end }}
 {{ end }}
 ```
 
 ## Options
 
-targetPath
-: (`string`) If not set, the source path will be used as the base target path.
+###### targetPath
+
+(`string`) If not set, the source path will be used as the base target path.
 Note that the target path's extension may change if the target MIME type is different, e.g. when the source is TypeScript.
 
-format
-: (`string`) The output format. One of: `iife`, `cjs`, `esm`. Default is `iife`, a self-executing function, suitable for inclusion as a `<script>` tag.
+###### format
+
+(`string`) The output format. One of: `iife`, `cjs`, `esm`. Default is `iife`, a self-executing function, suitable for inclusion as a `<script>` tag.
 
 {{% include "./_common/options.md" %}}
 
-### Import JS code from the assets directory
+## Import JS code from the assets directory
 
 `js.Build` has full support for the virtual union file system in [Hugo Modules](/hugo-modules/). You can see some simple examples in this [test project](https://github.com/gohugoio/hugoTestProjectJSModImports), but in short this means that you can do this:
 
@@ -68,7 +74,7 @@ import { hello3 } from 'my/module/hello3';
 
 Will resolve to `hello3.{js,ts,tsx,jsx}` inside `assets/my/module`.
 
-Any imports starting with `.` is resolved relative to the current file:
+Any imports starting with `.` are resolved relative to the current file:
 
 ```js
 import { hello4 } from './lib';
diff --git a/content/en/functions/js/_common/options.md b/content/en/functions/js/_common/options.md
index 332264fca..54fe7fca4 100644
--- a/content/en/functions/js/_common/options.md
+++ b/content/en/functions/js/_common/options.md
@@ -2,8 +2,9 @@
 _comment: Do not remove front matter.
 ---
 
-params
-: (`map` or `slice`) Params that can be imported as JSON in your JS files, e.g.
+###### params
+
+(`map` or `slice`) Params that can be imported as JSON in your JS files, e.g.
 
 ```go-html-template
 {{ $js := resources.Get "js/main.js" | js.Build (dict "params" (dict "api" "https://example.org/api")) }}
@@ -16,17 +17,23 @@ import * as params from '@params';
 
 Note that this is meant for small data sets, e.g. configuration settings. For larger data, please put/mount the files into `assets` and import them directly.
 
-minify
-: (`bool`)Let `js.Build` handle the minification.
+###### minify
 
-loaders
-: (`map`) {{< new-in "0.140.0" >}}  Configuring a loader for a given file type lets you load that file type with an import statement or a require call. For example configuring the .png file extension to use the data URL loader means importing a .png file gives you a data URLcontaining the contents of that image. Loaders available are `none`, `base64`, `binary`, `copy`,  `css`,  `dataurl`, `default`, `empty`, `file`, `global-css`, `js`, `json`, `jsx`, `local-css`,  `text`, `ts`, `tsx`. See https://esbuild.github.io/api/#loader
+(`bool`) Let `js.Build` handle the minification.
 
-inject
-: (`slice`) This option allows you to automatically replace a global variable with an import from another file. The path names must be relative to `assets`. See https://esbuild.github.io/api/#inject
+###### loaders
 
-shims
-: (`map`) This option allows swapping out a component with another. A common use case is to load dependencies like React from a CDN  (with _shims_) when in production, but running with the full bundled `node_modules` dependency during development:
+{{< new-in "0.140.0" >}}
+
+(`map`) Configuring a loader for a given file type lets you load that file type with an import statement or a require call. For example configuring the .png file extension to use the data URL loader means importing a .png file gives you a data URLcontaining the contents of that image. Loaders available are `none`, `base64`, `binary`, `copy`,  `css`,  `dataurl`, `default`, `empty`, `file`, `global-css`, `js`, `json`, `jsx`, `local-css`,  `text`, `ts`, `tsx`. See https://esbuild.github.io/api/#loader.
+
+###### inject
+
+(`slice`) This option allows you to automatically replace a global variable with an import from another file. The path names must be relative to `assets`. See https://esbuild.github.io/api/#inject.
+
+###### shims
+
+(`map`) This option allows swapping out a component with another. A common use case is to load dependencies like React from a CDN  (with _shims_) when in production, but running with the full bundled `node_modules` dependency during development:
 
 ```go-html-template
 {{ $shims := dict "react" "js/shims/react.js"  "react-dom" "js/shims/react-dom.js" }}
@@ -52,33 +59,49 @@ import * as React from 'react';
 import * as ReactDOM from 'react-dom/client';
 ```
 
-target
-: (`string`) The language target. One of: `es5`, `es2015`, `es2016`, `es2017`, `es2018`, `es2019`, `es2020` or `esnext`. Default is `esnext`.
+###### target
 
-platform {{< new-in 0.140.0 >}}
-: (`string`) One of `browser`, `node`, `neutral`.  Default is `browser`. See https://esbuild.github.io/api/#platform
+(`string`) The language target. One of: `es5`, `es2015`, `es2016`, `es2017`, `es2018`, `es2019`, `es2020` or `esnext`. Default is `esnext`.
 
-externals
-: (`slice`) External dependencies. Use this to trim dependencies you know will never be executed. See https://esbuild.github.io/api/#external
+###### platform
 
-defines
-: (`map`) Allow to define a set of string replacement to be performed when building. Should be a map where each key is to be replaced by its value.
+{{< new-in 0.140.0 >}}
+
+(`string`) One of `browser`, `node`, `neutral`.  Default is `browser`. See https://esbuild.github.io/api/#platform.
+
+###### externals
+
+(`slice`) External dependencies. Use this to trim dependencies you know will never be executed. See https://esbuild.github.io/api/#external.
+
+###### defines
+
+(`map`) Allow to define a set of string replacement to be performed when building. Should be a map where each key is to be replaced by its value.
 
 ```go-html-template
 {{ $defines := dict "process.env.NODE_ENV" `"development"` }}
 ```
 
-sourceMap
-: (`string`) Whether to generate `inline`, `linked` or `external` source maps from esbuild. Linked and external source maps will be written to the target with the output file name + ".map". When `linked` a `sourceMappingURL` will also be written to the output file. By default, source maps are not created. Note that the `linked` option was added in Hugo 0.140.0.
+###### sourceMap
 
-sourcesContent {{< new-in 0.140.0 >}}
-: (`bool`) Whether to include the content of the source files in the source map. By default, this is `true`.
+(`string`) Whether to generate `inline`, `linked` or `external` source maps from esbuild. Linked and external source maps will be written to the target with the output file name + ".map". When `linked` a `sourceMappingURL` will also be written to the output file. By default, source maps are not created. Note that the `linked` option was added in Hugo 0.140.0.
 
-JSX {{< new-in 0.124.0 >}}
-: (`string`) How to handle/transform JSX syntax. One of: `transform`, `preserve`, `automatic`. Default is `transform`. Notably, the `automatic` transform was introduced in React 17+ and will cause the necessary JSX helper functions to be imported automatically. See https://esbuild.github.io/api/#jsx
+###### sourcesContent
 
-JSXImportSource {{< new-in 0.124.0 >}}
-: (`string`) Which library to use to automatically import its JSX helper functions from. This only works if `JSX` is set to `automatic`. The specified library needs to be installed through npm and expose certain exports. See https://esbuild.github.io/api/#jsx-import-source
+{{< new-in 0.140.0 >}}
+
+(`bool`) Whether to include the content of the source files in the source map. By default, this is `true`.
+
+###### JSX
+
+{{< new-in 0.124.0 >}}
+
+(`string`) How to handle/transform JSX syntax. One of: `transform`, `preserve`, `automatic`. Default is `transform`. Notably, the `automatic` transform was introduced in React 17+ and will cause the necessary JSX helper functions to be imported automatically. See https://esbuild.github.io/api/#jsx.
+
+###### JSXImportSource
+
+{{< new-in 0.124.0 >}}
+
+(`string`) Which library to use to automatically import its JSX helper functions from. This only works if `JSX` is set to `automatic`. The specified library needs to be installed through npm and expose certain exports. See https://esbuild.github.io/api/#jsx-import-source.
 
 The combination of `JSX` and `JSXImportSource` is helpful if you want to use a non-React JSX library like Preact, e.g.: