mirror of
https://github.com/gohugoio/hugo.git
synced 2026-08-24 15:28:54 +00:00
a54c398b93
Add security.node.permissions config to run Node tools (PostCSS, Babel, TailwindCSS) under Node's permission model, restricting file system access to the working directory by default. The binary resolution is simplified to node_modules/.bin → PATH (npx removed). For both locations, the actual JS entry point is resolved via symlinks (macOS/Linux) or by parsing npm wrapper scripts (Windows .cmd), then executed as "node --permission --allow-fs-read=<path> --allow-fs-write=<path> <script>". Users can opt out by removing "node" from security.exec.allow. Closes #7287
217 lines
6.1 KiB
Go
217 lines
6.1 KiB
Go
// Copyright 2024 The Hugo Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package cssjs_test
|
|
|
|
import (
|
|
"fmt"
|
|
"path/filepath"
|
|
"runtime"
|
|
"strings"
|
|
"testing"
|
|
|
|
qt "github.com/frankban/quicktest"
|
|
"github.com/gohugoio/hugo/common/herrors"
|
|
"github.com/gohugoio/hugo/htesting"
|
|
"github.com/gohugoio/hugo/hugofs"
|
|
"github.com/gohugoio/hugo/hugolib"
|
|
)
|
|
|
|
const postCSSIntegrationTestFiles = `
|
|
-- assets/css/components/a.css --
|
|
/* A comment. */
|
|
/* Another comment. */
|
|
class-in-a {
|
|
color: blue;
|
|
}
|
|
|
|
-- assets/css/components/all.css --
|
|
@import "a.css";
|
|
@import "b.css";
|
|
-- assets/css/components/b.css --
|
|
@import "a.css";
|
|
|
|
class-in-b {
|
|
color: blue;
|
|
}
|
|
|
|
-- assets/css/styles.css --
|
|
@tailwind base;
|
|
@tailwind components;
|
|
@tailwind utilities;
|
|
@import "components/all.css";
|
|
h1 {
|
|
@apply text-2xl font-bold;
|
|
}
|
|
|
|
-- hugo.toml --
|
|
disablekinds = ['taxonomy', 'term', 'page']
|
|
baseURL = "https://example.com"
|
|
[build]
|
|
useResourceCacheWhen = 'never'
|
|
-- content/p1.md --
|
|
-- data/hugo.toml --
|
|
slogan = "Hugo Rocks!"
|
|
-- i18n/en.yaml --
|
|
hello:
|
|
other: "Hello"
|
|
-- i18n/fr.yaml --
|
|
hello:
|
|
other: "Bonjour"
|
|
-- layouts/home.html --
|
|
{{ $options := dict "inlineImports" true }}
|
|
{{ $styles := resources.Get "css/styles.css" | css.PostCSS $options }}
|
|
Styles RelPermalink: {{ $styles.RelPermalink }}
|
|
{{ $cssContent := $styles.Content }}
|
|
Styles Content: Len: {{ len $styles.Content }}|
|
|
-- package.json --
|
|
{
|
|
"scripts": {},
|
|
|
|
"devDependencies": {
|
|
"postcss-cli": "7.1.0",
|
|
"tailwindcss": "1.2.0"
|
|
}
|
|
}
|
|
-- postcss.config.js --
|
|
console.error("Hugo Environment:", process.env.HUGO_ENVIRONMENT );
|
|
console.error("Hugo PublishDir:", process.env.HUGO_PUBLISHDIR );
|
|
// https://github.com/gohugoio/hugo/issues/7656
|
|
console.error("package.json:", process.env.HUGO_FILE_PACKAGE_JSON );
|
|
console.error("PostCSS Config File:", process.env.HUGO_FILE_POSTCSS_CONFIG_JS );
|
|
|
|
module.exports = {
|
|
plugins: [
|
|
require('tailwindcss')
|
|
]
|
|
}
|
|
|
|
`
|
|
|
|
func TestTransformPostCSS(t *testing.T) {
|
|
if !htesting.IsCI() {
|
|
t.Skip("Skip long running test when running locally")
|
|
}
|
|
|
|
c := qt.New(t)
|
|
tempDir, clean, err := htesting.CreateTempDir(hugofs.Os, "hugo-integration-test")
|
|
c.Assert(err, qt.IsNil)
|
|
c.Cleanup(clean)
|
|
|
|
for _, s := range []string{"never", "always"} {
|
|
|
|
repl := strings.NewReplacer(
|
|
"https://example.com",
|
|
"https://example.com/foo",
|
|
"useResourceCacheWhen = 'never'",
|
|
fmt.Sprintf("useResourceCacheWhen = '%s'", s),
|
|
)
|
|
|
|
files := repl.Replace(postCSSIntegrationTestFiles)
|
|
|
|
b := hugolib.Test(c, files, hugolib.TestOptOsFs(), hugolib.TestOptWithNpmInstall(), hugolib.TestOptInfo(), hugolib.TestOptWithConfig(func(cfg *hugolib.IntegrationTestConfig) {
|
|
cfg.WorkingDir = tempDir
|
|
}))
|
|
|
|
b.AssertFileContent("public/index.html", `
|
|
Styles RelPermalink: /foo/css/styles.css
|
|
Styles Content: Len: 770917|
|
|
`)
|
|
|
|
if s == "never" {
|
|
b.AssertLogContains("Hugo Environment: production")
|
|
b.AssertLogContains("Hugo PublishDir: " + filepath.Join(tempDir, "public"))
|
|
}
|
|
}
|
|
}
|
|
|
|
// 9880
|
|
func TestTransformPostCSSError(t *testing.T) {
|
|
if !htesting.IsCI() {
|
|
t.Skip("Skip long running test when running locally")
|
|
}
|
|
|
|
if runtime.GOOS == "windows" {
|
|
// TODO(bep) This has started to fail on Windows with Go 1.19 on GitHub Actions for some mysterious reason.
|
|
t.Skip("Skip on Windows")
|
|
}
|
|
|
|
c := qt.New(t)
|
|
|
|
b, err := hugolib.TestE(c, strings.ReplaceAll(postCSSIntegrationTestFiles, "color: blue;", "@apply foo;"), hugolib.TestOptOsFs(), hugolib.TestOptWithNpmInstall())
|
|
|
|
ferrs := herrors.UnwrapFileErrors(err)
|
|
b.Assert(len(ferrs), qt.Equals, 2)
|
|
b.Assert(err.Error(), qt.Contains, "a.css:4:2")
|
|
}
|
|
|
|
// #9895
|
|
func TestTransformPostCSSImportError(t *testing.T) {
|
|
if !htesting.IsCI() {
|
|
t.Skip("Skip long running test when running locally")
|
|
}
|
|
|
|
c := qt.New(t)
|
|
|
|
_, err := hugolib.TestE(c, strings.ReplaceAll(postCSSIntegrationTestFiles, `@import "components/all.css";`, `@import "components/doesnotexist.css";`), hugolib.TestOptOsFs(), hugolib.TestOptWithNpmInstall(), hugolib.TestOptInfo())
|
|
ferrs := herrors.UnwrapFileErrors(err)
|
|
c.Assert(len(ferrs), qt.Equals, 2)
|
|
c.Assert(err.Error(), qt.Contains, "styles.css:4:3")
|
|
c.Assert(err.Error(), qt.Contains, filepath.FromSlash(`failed to resolve CSS @import "/css/components/doesnotexist.css"`))
|
|
}
|
|
|
|
func TestTransformPostCSSImporSkipInlineImportsNotFound(t *testing.T) {
|
|
if !htesting.IsCI() {
|
|
t.Skip("Skip long running test when running locally")
|
|
}
|
|
|
|
c := qt.New(t)
|
|
|
|
files := strings.ReplaceAll(postCSSIntegrationTestFiles, `@import "components/all.css";`, `@import "components/doesnotexist.css";`)
|
|
files = strings.ReplaceAll(files, `{{ $options := dict "inlineImports" true }}`, `{{ $options := dict "inlineImports" true "skipInlineImportsNotFound" true }}`)
|
|
|
|
s := hugolib.Test(c, files, hugolib.TestOptOsFs(), hugolib.TestOptWithNpmInstall(), hugolib.TestOptInfo())
|
|
|
|
s.AssertFileContent("public/css/styles.css", `@import "components/doesnotexist.css";`)
|
|
}
|
|
|
|
// Issue 9787
|
|
func TestTransformPostCSSResourceCacheWithPathInBaseURL(t *testing.T) {
|
|
if !htesting.IsCI() {
|
|
t.Skip("Skip long running test when running locally")
|
|
}
|
|
|
|
c := qt.New(t)
|
|
tempDir, clean, err := htesting.CreateTempDir(hugofs.Os, "hugo-integration-test")
|
|
c.Assert(err, qt.IsNil)
|
|
c.Cleanup(clean)
|
|
|
|
for i := range 2 {
|
|
files := postCSSIntegrationTestFiles
|
|
|
|
if i == 1 {
|
|
files = strings.ReplaceAll(files, "https://example.com", "https://example.com/foo")
|
|
files = strings.ReplaceAll(files, "useResourceCacheWhen = 'never'", " useResourceCacheWhen = 'always'")
|
|
}
|
|
|
|
b := hugolib.Test(c, files, hugolib.TestOptOsFs(), hugolib.TestOptWithNpmInstall(), hugolib.TestOptInfo(), hugolib.TestOptWithConfig(func(cfg *hugolib.IntegrationTestConfig) {
|
|
cfg.WorkingDir = tempDir
|
|
}))
|
|
|
|
b.AssertFileContent("public/index.html", `
|
|
Styles Content: Len: 770917
|
|
`)
|
|
|
|
}
|
|
}
|